search

gogo / grpc-example

An example of using Go gRPC and tools from the greater gRPC ecosystem together with the GoGo Protobuf Project.
Other
453 stars 87 forks source link

Switch away from gogo/status #13

Closed johanbrandhorst closed 6 years ago

johanbrandhorst commented 6 years ago

Ridicolously enough, this now works :nerd_face:.

Fixes #12

awalterschulze commented 6 years ago

wat! really?

So we can even delete the gogo/status package?

johanbrandhorst commented 6 years ago

As far as I can tell... But the gogo/status package is still necessary if you're working with types that don't define XXX_MessageName or use goproto_registration. That's probably a very narrow use case.

awalterschulze commented 6 years ago

Should the example.proto maybe then include?

option (gogoproto.messagename_all) = true;
johanbrandhorst commented 6 years ago

Good idea. I briefly played around with removing goproto_registration but it's still necessary because grpc-gateway calls to proto.EnumValueMap when resolving query parameters:

https://github.com/grpc-ecosystem/grpc-gateway/blob/261dafe7abb6a223549d14d02faccffea736b7e8/runtime/query.go

johanbrandhorst commented 6 years ago

Bump :(?

awalterschulze commented 6 years ago

Interesting. I replied via email a day ago, but it didn't seem to arrive as a comment here. Sorry.

awalterschulze commented 6 years ago

Good to know about proto.EnumValueMap. Very interesting.