Use BSD-compatible syntax for sed command in Makefile

gogo / grpc-example

An example of using Go gRPC and tools from the greater gRPC ecosystem together with the GoGo Protobuf Project.

Other

453 stars 87 forks source link

Use BSD-compatible syntax for sed command in Makefile #24

Closed davidklassen closed 6 years ago

davidklassen commented 6 years ago

Fixes https://github.com/gogo/grpc-example/issues/23

johanbrandhorst commented 6 years ago

Hi @davidklassen! Thanks for your contribution. This is a great find, obviously I hadn't tested this on BSD platforms :thinking:. I've tested this on my platform (linux amd64) and it looks fine as well. Silly though it may sound, could you also update the blurb example in the README?

Thanks!

davidklassen commented 6 years ago

Hi @johanbrandhorst, done.

johanbrandhorst commented 6 years ago

LGTM

Thanks alot!