search

gogo / grpc-example

An example of using Go gRPC and tools from the greater gRPC ecosystem together with the GoGo Protobuf Project.
Other
453 stars 87 forks source link

AddUser method panics #29

Closed sevein closed 5 years ago

sevein commented 5 years ago

Hi there! I really appreciate the time spent putting this example together - it's pretty awesome!

Testing it locally, I've found that the server panics in the AddUser method when I connect the client.

I managed to fix it by returning a &types.Empty{} instead of nil. I'm curious to know why that didn't happen to the person writing it! These are my changes: https://gist.github.com/sevein/ddbec1c4e00ea3c3e1c14c8efb5c335b.

johanbrandhorst commented 5 years ago

Ah, this is because I recently updated the dependencies. Could you submit a pull request with your changes?