search

gogo / grpc-example

An example of using Go gRPC and tools from the greater gRPC ecosystem together with the GoGo Protobuf Project.
Other
454 stars 88 forks source link

Create CI test that ensure generated files have not changed #5

Closed johanbrandhorst closed 6 years ago

johanbrandhorst commented 6 years ago

It can use the scripts from gogo/googleapis as mentioned in https://github.com/gogo/grpc-example/pull/4#discussion_r170446725.

This should include splitting the third_party folder generation assets into a separate Makefile job as it is generation-time dependant.

awalterschulze commented 6 years ago

Sounds good.

Are you able to create a travis job, now that you are a member of gogo?

johanbrandhorst commented 6 years ago

I added Travis to the repo but when I triggered a build it failed. I will look into it later, a bit busy today. Feel free to fix it if you know what's missing. I have no prior experience with Travis.

awalterschulze commented 6 years ago

Take your time.

Is there some other free builder you do have experience with?

johanbrandhorst commented 6 years ago

I use an advanced CircleCI setup to test the GopherJS gRPC-web bindings, but I want to learn to use Travis too :).

awalterschulze commented 6 years ago

I have heard good things about circle ci, so it is definitely an option instead of travis, but your choice.

On Sun, 25 Feb 2018, 15:04 Johan Brandhorst, notifications@github.com wrote:

I use an advanced CircleCI setup to test the GopherJS gRPC-web bindings, but I want to learn to use Travis too :).

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gogo/grpc-example/issues/5#issuecomment-368311862, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvsLfGubAuAJRRQN9x4uN1FDecKzpu8ks5tYWh_gaJpZM4SSPOr .