search

gogo / letmegrpc

[maintainer wanted] generates a web form gui from a grpc specification
BSD 3-Clause "New" or "Revised" License
419 stars 50 forks source link

Special chars in comments are breaking the output #23

Closed utrack closed 8 years ago

utrack commented 8 years ago

If protobuf fields' comments contain any quote-like symbols then something usually breaks. i.e. ` breaks go code and ' breaks javascript.

I'll fix it later if nobody else picks the issue up first,

awalterschulze commented 8 years ago

Thanks. I have quite a lot on my plate at the moment. The comments on the fields are used to generate user hints. I can see how a ' can break this for the javascript. I don't understand why ` would break the go code, but if it is breaking it should be investigated.

utrack commented 8 years ago

I understand :) Well the whole HTML is stored verbatim in a variable with -quoted string, so if a string itself contains then it is considered as the trailing quote. This corrupts the generated go code.