search

gogo / letmegrpc

[maintainer wanted] generates a web form gui from a grpc specification
BSD 3-Clause "New" or "Revised" License
421 stars 48 forks source link

Attempted fix for same func and var names #42

Open MSalopek opened 6 years ago

MSalopek commented 6 years ago

This should enable the user to choose whether or not they want all code to be generated or just the code that returns a map of all available methods -> by using the flag "skip-defaults". Also, Headers and Footers get renamed: HeaderFileName and FooterFileName so every file would have different header and footer names. Please review.

awalterschulze commented 6 years ago

Is it possible to only give each file unique Header and Footer names, to avoid same func and var names? That way we won't need another flag?

MSalopek commented 6 years ago

I'm sorry, would you please elaborate your idea? Thanks!

awalterschulze commented 6 years ago

I was wondering whether it is possible to not have the skip defaults flag and still avoid the name conflicts, by only renaming the HeaderaFilename and FooterFilename to be unique for each file in the folder?

On Mon, 19 Mar 2018, 09:28 MSalopek, notifications@github.com wrote:

I'm sorry, would you please elaborate your idea? Thanks!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gogo/letmegrpc/pull/42#issuecomment-374134631, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvsLYw_-eOr01pxgSe8G-LIEOjj3n7zks5tf2xCgaJpZM4Sqauj .

MSalopek commented 6 years ago

It is possible, yes. But the name func NewHandler will remain the same for all the files, that is something you would like to keep?