search

gogo / letmegrpc

[maintainer wanted] generates a web form gui from a grpc specification
BSD 3-Clause "New" or "Revised" License
421 stars 48 forks source link

form: fix isNumber json precision #53

Closed scbizu closed 5 years ago

awalterschulze commented 5 years ago

So basically numbers are strings after this diff, so there is less form validation?

Is marshalling to json still producing a number and not a quoted string? On Fri, 21 Dec 2018 at 06:05, scnace notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/gogo/letmegrpc/pull/53 Commit Summary

  • form: fix isNumber json precision

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gogo/letmegrpc/pull/53, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvsLS5lIarTGfEgUyfsUDSEg8eBj0jAks5u7F4PgaJpZM4ZdUlZ .

scbizu commented 5 years ago

oh, my wrong .

scbizu commented 5 years ago

It will be fixed now.

awalterschulze commented 5 years ago

@donaldgraham @jmarais I am happy with this change, but would just like to know if you are still using this and if so if you are ok with int64s now being printed in the url using quotes, while urls where int64s are printed without using quotes will still be parsable into the form.

jmarais commented 5 years ago

@awalterschulze I am happy with this change.

awalterschulze commented 5 years ago

If you are happy please merge :)

On Mon, 3 Jun 2019 at 14:50, jmarais notifications@github.com wrote:

@awalterschulze https://github.com/awalterschulze I am happy with this change.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/gogo/letmegrpc/pull/53?email_source=notifications&email_token=AAN6YLMVGSOU43WGS7GQSFTPYUOR5A5CNFSM4GLVJFM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZOXCY#issuecomment-498264971, or mute the thread https://github.com/notifications/unsubscribe-auth/AAN6YLPSDPDBRDZRZAUUGJTPYUOR5ANCNFSM4GLVJFMQ .

jmarais commented 5 years ago

@scbizu We would like to merge this, could you please merge master into your branch and resolve the conflicts. It just seems like generation conflicts.

scbizu commented 5 years ago

okay, I will .

scbizu commented 5 years ago

It seems everything is ok ? /cc @jmarais

jmarais commented 5 years ago

@scbizu Thanks. The last travis job was probably stale.