search

gogo / letmegrpc

[maintainer wanted] generates a web form gui from a grpc specification
BSD 3-Clause "New" or "Revised" License
421 stars 48 forks source link

regenerate with go1.12 and protoc 3.7.1 #56

Closed jmarais closed 5 years ago

jmarais commented 5 years ago

Regeneration with go1.12 and protoc 3.7.1.

This was just cloning the repo, running make and updating the travis config.

Edit: I seemed to push my url fix to the wrong branch. However If you are happy with both changes I will keep this request up. Let me know if you want to split the changes into two request.

We have an issue with the generation of the webform when there are specials characters present in the URL Variables. If you have a variable with a string containing "==" the splitting code will break up that string an create an invalid json object. The url parsing code will fail and an malformed webform will appear. This getUrlParameter function was updated according to this SO discussion: https://stackoverflow.com/a/8486188

awalterschulze commented 5 years ago

LGTM please merge

On Mon, 3 Jun 2019 at 12:47, jmarais notifications@github.com wrote:

@jmarais https://github.com/jmarais requested your review on: #56 https://github.com/gogo/letmegrpc/pull/56 regenerate with go1.12 and protoc 3.7.1.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/gogo/letmegrpc/pull/56?email_source=notifications&email_token=AAN6YLOA47S2ANGPW5VMWXTPYUADRA5CNFSM4HSHDCFKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORYRDPIQ#event-2384607138, or mute the thread https://github.com/notifications/unsubscribe-auth/AAN6YLPESGWSC73D6TJGG5DPYUADRANCNFSM4HSHDCFA .