Refactoring - Githubissues

gogotanaka / Rubype

:dromedary_camel: Super simple, clean. Contracts for Ruby

http://gogotanaka.github.io/rubype.github.io/

377 stars 14 forks source link

Closed stefkin closed 9 years ago

stefkin commented 9 years ago

Sorry if I broke some of the principles that you was following. I assumed that you value conciseness above other aspects.

Using guard statements instead of full sized conditional statements should shorten methods a little bit.
Using then instead of ; after when is recommended by community styleguide, as well as identation after assignment
Using assignment in conditional statement may be misleading

Thank you for such an elegant implementation of contracts, 79 lines is impressive.

gogotanaka commented 9 years ago

@bublik42 I really like it!! :dancer:

You already have enough skills on committing by yourself, so added you to the repo so you can just commit ;)

Please use it if you want. thanks.