gogs / gogs

Gogs is a painless self-hosted Git service
https://gogs.io
MIT License
45.17k stars 4.87k forks source link

public folder dont use STATIC_ROOT_PATH #468

Closed klausenbusk closed 10 years ago

klausenbusk commented 10 years ago

Hello

It seems like the public folder, don't use STATIC_ROOT_PATH, but use the path where gogs is run from.

Just tested: /usr/share/gogs/start.sh running from /usr/share/gogs/ skaermbillede fra 2014-09-15 20 15 53 /usr/share/gogs/start.sh running from /usr/share/themes/goges/default skaermbillede fra 2014-09-15 20 16 33

with STATIC_ROOT_PATH = /usr/share/themes/goges/default

Gogs version 0.5.0.0913 Beta

fanningert commented 10 years ago

@klausenbusk: I think in your post are the screenshots in a wrong order.

With STATIC_ROOT_PATH = /usr/share/gogs/ it is working. With STATIC_ROOT_PATH = /usr/share/themes/gogs/default it is not working.

The directories public and template are in the two directories (/usr/share/gogs/ and /usr/share/themes/gogs/default).

klausenbusk commented 10 years ago

It not the STATIC_ROOT_PATH, it the working dir.

fanningert commented 10 years ago

Ok, know I check your explain and you description is correct.

unknwon commented 10 years ago

I've updated dev branch to fix this, somehow when merge the old and new UI, I rewrote the templates right, but public wrong.

fanningert commented 10 years ago

dev-branch is now working.

unknwon commented 10 years ago

Good, sorry about that, need release v0.5.1 soon I guess.

fanningert commented 10 years ago

No problem, v0.5.0 is a great release. So it is normal, that are some bugs. :)