search

goharbor / harbor-arm

Build Harbor for arm architecture.
Apache License 2.0
70 stars 43 forks source link

Feat/ci workflow #6

Closed Jeremy-boo closed 2 years ago

Jeremy-boo commented 2 years ago

harbor-arm add ci workflow

tianon commented 2 years ago

It seems like a lot of this is copied from the main Harbor repository -- won't that make it hard to maintain in the future, especially as the main repository is updated over time?

If it didn't have to change very much to make it work on ARM, wouldn't it be better to have the scripts here download the original copy from the Harbor repository instead, making whatever minor changes are necessary programmatically instead of manually? I would think that'd make it easier to continue to maintain over time (and make sure it doesn't miss any future additions to the main Harbor repository for new features, etc).

Jeremy-boo commented 2 years ago

It seems like a lot of this is copied from the main Harbor repository -- won't that make it hard to maintain in the future, especially as the main repository is updated over time?

If it didn't have to change very much to make it work on ARM, wouldn't it be better to have the scripts here download the original copy from the Harbor repository instead, making whatever minor changes are necessary programmatically instead of manually? I would think that'd make it easier to continue to maintain over time (and make sure it doesn't miss any future additions to the main Harbor repository for new features, etc).

yeah, the current harbor-arm construction workflow and ci workflow are copied from the harbor repo. There is no better way to build the arm image. We will try to use a better way to build the harbor-arm image in 2.4.0 to avoid strong dependency between harbro-arm and harbor main repo