search

goharbor / harbor-helm

The helm chart to deploy Harbor
Apache License 2.0
1.18k stars 758 forks source link

Workload's labels isn't following the recommendation of labels from Kubernetes. #1045

Open JhoLee opened 3 years ago

JhoLee commented 3 years ago

tl;dr Suggesting Harbor Helm Chart to follow the [Kubernetes Labels Recommendation](backward compatibility).

I'm using Harbor and many apps with helm. And I use their kubernetes labels usefully like; 1) Collecting metrics with Prometheus. 2) Managing workloads.

But I knew that Harbor Helm has not follwed Kubernetes' label recommendation. (More information)

So I suggest Harbor to follow this recommendation. Or I will commit it by myself, and I'll request for review.

Thank you.

ninjadq commented 3 years ago

Hi @JhoLee , thank you for mention this, could you help to commit a PR to add this label to harbor-helm, we already have some similar labels but not follow the k8s recommendation, you should keep them and add the new ones. Because some user may depend those labels in production

JhoLee commented 3 years ago

@ninjadq OK. I'll commit it with backward compatibility.

JhoLee commented 3 years ago

@ninjadq I committed those labels with backward compatibility!

martinnirtl commented 1 year ago

Hello!! Any update on this?

billabongrob commented 5 months ago

Yeah, curious as well. Seems like none of the deployments or statefulsets inherit any of these labels. 😢