jwojnarowicz commented 6 months ago

Hello,

I am happy to share me Pull Request that addresses issues I encountered during working with Harbor Helm.

What improvements does these changes make?

Adds separation between update strategies for both persistent volume dependent deployments - jobservice and registry,
When someone uses s3 like backend, there is no need to change the strategy to Recreate as it does not depend on PVC and RWM/RWO access,
When someone still has to use Recreate strategy for jobservice running on PVC in RWO and at the same time does not use PVC for registry storage, then Recreate creates unavailability of registry pods during update even though there is no such need.

I have also changed the README.md to reflect the changes. If you prefer I can also put these options inside jobservice and registry options then it would be jobservice.updateStrategy.type instead (and same for registry).

Cheers 😄

jwojnarowicz commented 6 months ago

@MinerYang can you check?

github-actions[bot] commented 4 months ago

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] commented 3 months ago

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

goharbor / harbor-helm

Separate updateStrategy configuration for jobservice and registry deployments #1728

What improvements does these changes make?