goharbor / harbor-helm

The helm chart to deploy Harbor
Apache License 2.0
1.18k stars 760 forks source link

feat: manage the fsGroupChangePolicy configuration using the values.yaml #1762

Closed wuzhihui1123 closed 3 months ago

wuzhihui1123 commented 4 months ago

Move the fsGroupChangePolicy value of the registry to the values.yaml, so that different field values can be configured for it.

zyyw commented 3 months ago

please raise PR against the main branch

zyyw commented 3 months ago

https://github.com/goharbor/harbor-helm/blob/f547605c75badb6675810327cc4809b3ec4202a8/templates/registry/registry-dpl.yaml#L92

https://github.com/goharbor/harbor-helm/blob/f547605c75badb6675810327cc4809b3ec4202a8/templates/registry/registry-dpl.yaml#L231

users can configure it via the containerSecurityContext.

wuzhihui1123 commented 3 months ago

https://github.com/goharbor/harbor-helm/blob/f547605c75badb6675810327cc4809b3ec4202a8/templates/registry/registry-dpl.yaml#L92

https://github.com/goharbor/harbor-helm/blob/f547605c75badb6675810327cc4809b3ec4202a8/templates/registry/registry-dpl.yaml#L231

users can configure it via the containerSecurityContext.

Certainly! Here is the translation:


Users can configure the spec.containers[*].securityContext vaule within a pod using .Values.containerSecurityContext, but the spec.securityContext under the pod cannot be configured. The fsGroupChangePolicy value under it is fixed to OnRootMismatch, which makes it impossible to deploy services in Kubernetes versions <=1.20. My modification allows the pod to support custom values for the spec.securityContext field, making it compatible with deployments in lower versions of Kubernetes.

Can you help reopen my pull request? @zyyw

image
Vad1mo commented 3 months ago

@wuzhihui1123 wir only Support k8s >= 1.20. There is no intent to support older k8s version

wuzhihui1123 commented 2 months ago

@wuzhihui1123 wir only Support k8s >= 1.20. There is no intent to support older k8s version

Well, it seems I have to fork my own repository. 😂 @Vad1mo