goharbor / harbor-helm

The helm chart to deploy Harbor
Apache License 2.0
1.18k stars 760 forks source link

Separate logLevel for jobservice #1763

Closed mmclane closed 3 months ago

mmclane commented 4 months ago

Today you can only specify logLevel once for the whole chart and that loglevel gets used in all of the services.

I want to use Error for most of the services to tone down the logs a bunch but when I do that I loose the logging for the jobservice. This leads to an empty log meaning you can not watch the progress of the job. I want to be able to specify .Values.jobservice.logLevel and if specified have it used instead of .Values.logLevel. This would allow you to set logLevel to error for everything but still get info level logs for the jobservice.

I actually think this pattern should be done throughout the helm chart but the jobservice is the one currently keeping me from setting the log level the to error.

mmclane commented 4 months ago

I went ahead and created a PR with what I think would solve this for jobservice.

zyyw commented 3 months ago

Since the upstream goharbor/harbor does not support this, we may not enable this for jobsservice only in harbor-helm.