goharbor / harbor-helm

The helm chart to deploy Harbor
Apache License 2.0
1.19k stars 760 forks source link

Refactor YAML to Use Template Values for Security Context #1819

Closed Nithinrao9696 closed 2 months ago

Nithinrao9696 commented 2 months ago

Summary

This PR updates the YAML configuration to replace hardcoded values for runAsUser and fsGroup with templated values. This change enhances the configurability and maintainability of the configuration files.

Details

These changes allow for more flexible configuration management by enabling the values to be defined dynamically based on the values provided in the Helm chart's values file.

Impact

How to Test

  1. Ensure that the Helm values file (values.yaml or equivalent) contains the necessary runAsUser and fsGroup values under the database.securityContext section.
  2. Deploy or render the Helm chart to verify that the YAML configuration reflects the templated values as expected.

Additional Notes

Please review the changes and provide feedback.

Nithinrao9696 commented 2 months ago

@Vad1mo please check when you get a chance

Nithinrao9696 commented 2 months ago

can someone please take appropriate action on this?

MinerYang commented 2 months ago

Hi @Nithinrao9696 ,

Thanks for contributing for harbor-helm, however this pod-level security contexts do not needs anymore actually, and we don't have any plan to expose this as a configuration anymore. Please kindly use the container-level security contexts.

I would like to close this PR per above comments.

Best, Miner