Closed DeeAjayi closed 1 year ago
LGTM, but tests are broken, but it doesn't look to be because of your PR.
Since the limit of secret in kube is 1MB and helm manages its revisions via secret, adding these new fields in CRD broke the harbor-operator installation of pipeline. https://kubernetes.io/docs/concepts/configuration/secret/#restriction-data-size
We should install CRDs first with kubectl
and helm upgrade/install harbor-operator with flag installCRDs=false
to avoid having long secret of helm release https://helm.sh/docs/chart_best_practices/custom_resource_definitions/
@DeeAjayi Can you rebase this PR on the latest master? It should resolve all the issues we had with testing.
@MarcelMue done
@MarcelMue done
Somehow the diff / signing got screwed up. Can you check if you can fix the signing?
Yes looking into it
@MarcelMue the failed DCO step has been fixed
Thanks for the help @DeeAjayi !
@DeeAjayi - congrats on merging your first PR here mate :)
Signed-off-by: Oladipupo Ajayi ajayidipo@ymail.com