goharbor / harbor-operator

Kubernetes operator for Harbor service components
Apache License 2.0
350 stars 107 forks source link

Add Redis service account name to CRD #1001

Closed DeeAjayi closed 1 year ago

DeeAjayi commented 1 year ago

Signed-off-by: Oladipupo Ajayi ajayidipo@ymail.com

thcdrt commented 1 year ago

LGTM, but tests are broken, but it doesn't look to be because of your PR.

hungluong commented 1 year ago

Since the limit of secret in kube is 1MB and helm manages its revisions via secret, adding these new fields in CRD broke the harbor-operator installation of pipeline. https://kubernetes.io/docs/concepts/configuration/secret/#restriction-data-size We should install CRDs first with kubectl and helm upgrade/install harbor-operator with flag installCRDs=false to avoid having long secret of helm release https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

MarcelMue commented 1 year ago

@DeeAjayi Can you rebase this PR on the latest master? It should resolve all the issues we had with testing.

DeeAjayi commented 1 year ago

@MarcelMue done

MarcelMue commented 1 year ago

@MarcelMue done

Somehow the diff / signing got screwed up. Can you check if you can fix the signing?

DeeAjayi commented 1 year ago

Yes looking into it

DeeAjayi commented 1 year ago

@MarcelMue the failed DCO step has been fixed

MarcelMue commented 1 year ago

Thanks for the help @DeeAjayi !

OrlinVasilev commented 1 year ago

@DeeAjayi - congrats on merging your first PR here mate :)