search

goharbor / harbor-operator

Kubernetes operator for Harbor service components
Apache License 2.0
350 stars 107 forks source link

upgrade controller-runtime version #1034

Closed CoderTH closed 1 year ago

CoderTH commented 1 year ago

issue #1033

thcdrt commented 1 year ago

Hello, Why closing it ?

CoderTH commented 1 year ago

Hello, Why closing it ?

hello There are still some problems in the code, there is no time to do it in the first two days, so it is closed temporarily. I will repair these problems and then reopen this PR

thcdrt commented 1 year ago

Ho ok, no problem. Tell me when you want us to review.

CoderTH commented 1 year ago

@thcdrt hi can you help me run the ci pipeline ?

CoderTH commented 1 year ago

Ho ok, no problem. Tell me when you want us to review.

please review this pr and help me run ci again

CoderTH commented 1 year ago

@thcdrt i don't know why theGenerated files are up to date and chart K8S xxx ci step error , can you take a look at it for me ？

MarcelMue commented 1 year ago

@thcdrt i don't know why theGenerated files are up to date and chart K8S xxx ci step error , can you take a look at it for me ？

There is a generate target in the makefile to generate all necessary files: https://github.com/goharbor/harbor-operator/blob/4cabfa9fc4a8692a3894640cc597fcf704a96d27/Makefile#L201-L202

thcdrt commented 1 year ago

Waiting for helm chart packaging fix before merging.

MarcelMue commented 1 year ago

Please rebase / resolve conflicts to see if we are good now 🙇‍♂️

CoderTH commented 1 year ago

Please rebase / resolve conflicts to see if we are good now 🙇‍♂️

ok, done please help me run ci again

CoderTH commented 1 year ago

@thcdrt @MarcelMue It look like ci pipeline is ok now

CoderTH commented 1 year ago

Thanks for your review and support 🙇 @thcdrt @MarcelMue （But there doesn't seem to be an auto-merge

MarcelMue commented 1 year ago

I can merge - thanks for your help!

I will create a follow up issue to check if we need to do some more testing later on.

CoderTH commented 1 year ago

I can merge - thanks for your help!

I will create a follow up issue to check if we need to do some more testing later on.

Ok, If there are any follow-up cases that I can help with, I would be happy to do so.

MarcelMue commented 1 year ago

Please check if everything in your projects which imports harbor operator works correctly now :)

I think we mostly need some more test cases for current and new functionality, but there is nothing I can point you to right now