Closed LiuShuaiyi closed 1 year ago
Please don't merge yet (hopefully some of the checks will break). It's missing at least charts/harbor-operator/templates/crds.yaml
.
edited: nvm just found that charts/harbor-operator/templates/crds.yaml
was removed.
@MarcelMue @wy65701436 @chlins should we merge it now ? Or do we wait to recreate 1.4 release branch first ?
@MarcelMue @wy65701436 @chlins should we merge it now ? Or do we wait to recreate 1.4 release branch first ?
I think it's fine to merge now. Also why is CI stuck so weirdly? I am uncertain why github actions are not running.
@MarcelMue @wy65701436 @chlins should we merge it now ? Or do we wait to recreate 1.4 release branch first ?
I think it's fine to merge now. Also why is CI stuck so weirdly? I am uncertain why github actions are not running.
I just asked me the same question in another PR, I don't understand neither... @wy65701436 @chlins do you have an idea ?
Gentle ping @chlins @holyhope. Looks like I need an approval from a maintainer to trigger the workflows.
The PR failed at test the following test:
Test Case - Tag Immutability Filesystem Size Used Avail Use% Mounted on
overlay 84G 76G 7.4G 92% /
tmpfs 64M 0 64M 0% /dev
shm 64M 0 64M 0% /dev/shm
/dev/root 84G 76G 7.4G 92% /drone
none 3.4G 0 3.4G 0% /tmp
| FAIL |
1 != 0
I don't think this failure is related to my change, right? Is it possible to re-run the test or merge it?
@LiuShuaiyi congrats on merging your first PR here!
Allow to change core.spec.database.maxIdleConnections and core.spec.database.maxOpenConnections in harborcluster.