search

goharbor / harbor-scanner-clair

Use Clair as a plug-in vulnerability scanner in the Harbor registry
https://goharbor.io/
Apache License 2.0
35 stars 26 forks source link

Enhance: add minversion and cipher for tls #18

Closed ninjadq closed 4 years ago

ninjadq commented 4 years ago

Min Version tls set to tls1.2 cipher suite only supoort ecdhe

Signed-off-by: DQ dengq@vmware.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will decrease coverage by 18.49%. The diff coverage is 40.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #18       +/-   ##
===========================================
- Coverage   68.85%   50.35%   -18.50%     
===========================================
  Files           7       13        +6     
  Lines         350      556      +206     
===========================================
+ Hits          241      280       +39     
- Misses         97      259      +162     
- Partials       12       17        +5
Impacted Files Coverage Δ
pkg/clair/client.go 0.00% <0.00%> (ø)
pkg/http/api/base_handler.go 73.91% <ø> (ø)
pkg/http/api/server.go 0.00% <0.00%> (ø)
pkg/registry/client.go 0.00% <ø> (ø)
pkg/scanner/enqueuer.go 0.00% <0.00%> (ø)
pkg/scanner/worker.go 0.00% <0.00%> (ø)
pkg/work/work.go 0.00% <0.00%> (ø)
pkg/etc/config.go 44.44% <30.00%> (-13.46%) :arrow_down:
pkg/scanner/adapter.go 70.00% <70.00%> (ø)
pkg/harbor/model.go 85.71% <71.42%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b8ec34...3e9154f. Read the comment docs.

ninjadq commented 4 years ago

Hi @danielpacak , could you please review this PR? I am concening the code coverage decreased too much, Is that normal?

danielpacak commented 4 years ago

Hi @danielpacak , could you please review this PR? I am concening the code coverage decreased too much, Is that normal?

@ninjadq I've added server_test.go since the last report was generated. That's the reason why this time it seems that the coverage decreased. Never mind, it's not because of your PR, it's because we started measuring coverage properly ;)