search

goharbor / harbor

An open source trusted cloud native registry project that stores, signs, and scans content.
https://goharbor.io
Apache License 2.0
23.89k stars 4.74k forks source link

what registry_DO_NOT_USE_GC mean in registryctl Dockerfile and registry Dockerfile #12300

Closed 7error closed 4 years ago

7error commented 4 years ago

I notice there is a name change 

COPY ./make/photon/registry/binary/registry /usr/bin/registry_DO_NOT_USE_GC

in these files

https://github.com/goharbor/harbor/blob/v2.0.0/make/photon/registry/Dockerfile#L7
https://github.com/goharbor/harbor/blob/v2.0.0/make/photon/registryctl/Dockerfile#L6
https://github.com/goharbor/harbor/blob/v2.0.0/src/registryctl/api/registry.go#L41

And before v2.0 registryctl Dockfer file is /usr/bin/registry，why change name of binary/registry to registry_DO_NOT_USE_GC? Does it have any deep meaning?

https://github.com/goharbor/harbor/commit/ff2a6c7a0167d3a4698879922644ac8b277d3ce9
wy65701436 commented 4 years ago

Please refer to https://github.com/goharbor/harbor/issues/11606 to get the background, and the reason of renaming it is just want to tell user DO NOT USE GC command inside the registy/regsityctl container. Whenever user wants to use GC, just click GC Now or call Harbor GC API to do it.

7error commented 4 years ago

Got it，tks

KeithTt commented 1 year ago

Please refer to #11606 to get the background, and the reason of renaming it is just want to tell user DO NOT USE GC command inside the registy/regsityctl container. Whenever user wants to use GC, just click GC Now or call Harbor GC API to do it.

Hi, I have clicked GC NOW on the portal, but disk space still didn't release, anything else?