search

goharbor / harbor

An open source trusted cloud native registry project that stores, signs, and scans content.
https://goharbor.io
Apache License 2.0
23.93k stars 4.74k forks source link

Testing Harbor Against Distribution v3 #20815

Open iseyer opened 2 months ago

iseyer commented 2 months ago

Distribution is (seemingly) close to releasing 3.0.0 - https://github.com/distribution/distribution/releases/tag/v3.0.0-beta.1

Notably, this release removes the need for the redis patch contained inside harbor by natively supported redis sentinel, and would in theory allow the use of the upstream repository directly: https://github.com/distribution/distribution/pull/4306

Describe the solution you'd like Remove, at a minimum, the redis distribution patch from harbor, and identify any other breaking changes (or new features!) that would require change on the harbor side

Describe the main design/architecture of your solution

  1. Remove the redis-patch, and replace redigo+Fzambia/sentinel with go-redis.
  2. Begin testing harbor installations built against distribution@v3.0.0-beta.1
  3. Identify and correct any existing issues, while adding support for new features

Describe the development plan you've considered I am preparing a PR to remove the redis patch and build against distribution@3.0.0-beta.1; I am happy and available to make these contributions, but would like to do so under the guidance of the maintainers to avoid stepping on the toes of potentially in-progress work, or making design decisions that the community is not in favor of.

Additional context Distribution has a potential lack of sponsorship at the moment, and one of their maintainers has indicated that they are unsure "if anything beyond the v3 release will happen." I am curious about how this will impact harbor should that project be marked as unmaintained.

https://github.com/distribution/distribution/pull/4425/files#r1703909047 https://github.com/distribution/distribution/discussions/4328

This makes me doubt the accuracy of the 3.0 milestone, though there have been lots of commits against main for that release: https://github.com/distribution/distribution/milestone/22

github-actions[bot] commented 1 week ago

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

sizowie commented 1 week ago

Not stale

Vad1mo commented 1 day ago

Here is my feedback so far.

I noticed some annoyances and one fixable breaking change. Aside from that, it is working smoothly.

Annoyance

Breaking Change