goharbor / harbor

An open source trusted cloud native registry project that stores, signs, and scans content.
https://goharbor.io
Apache License 2.0
24.25k stars 4.77k forks source link

Add manifestcache push for tag and digest to local repository #21141

Closed raphaelzoellner closed 2 weeks ago

raphaelzoellner commented 2 weeks ago

Comprehensive Summary of your change

Harbor Proxies will push a manifest referencing a digest and tag to the local repo if both are known.

Issue being fixed

Fixes #21122

Please indicate you've done the following:

stonezdj commented 2 weeks ago

Thanks for your contribution! because the current code change doesn't fix the issue #21122, and might result in regression issue, so we will close this PR.

raphaelzoellner commented 2 weeks ago

Hello @stonezdj,

could you give a hint why this code change (creating the manifest referenced by the tag) wouldn't solve or at least improve the described behavior in #21122, so one can think about another solution?

Is this maybe a misunderstanding with the PR https://github.com/goharbor/harbor/pull/21123, which is already closed?