goharbor / harbor

An open source trusted cloud native registry project that stores, signs, and scans content.
https://goharbor.io
Apache License 2.0
24.25k stars 4.77k forks source link

fix: event-based replication deletion not work when policy with label #21215

Closed chlins closed 1 hour ago

chlins commented 6 days ago

Fix event-based replication deletion on remote registry not triggered when the replication policy configured the label filter.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes https://github.com/goharbor/harbor/issues/21213

Please indicate you've done the following:

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.21%. Comparing base (c8c11b4) to head (5757553). Report is 335 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/goharbor/harbor/pull/21215/graphs/tree.svg?width=650&height=150&src=pr&token=6SOPrJGDVW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goharbor)](https://app.codecov.io/gh/goharbor/harbor/pull/21215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goharbor) ```diff @@ Coverage Diff @@ ## main #21215 +/- ## ========================================== + Coverage 45.36% 46.21% +0.84% ========================================== Files 244 247 +3 Lines 13333 13863 +530 Branches 2719 2867 +148 ========================================== + Hits 6049 6407 +358 - Misses 6983 7119 +136 - Partials 301 337 +36 ``` | [Flag](https://app.codecov.io/gh/goharbor/harbor/pull/21215/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goharbor) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/goharbor/harbor/pull/21215/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goharbor) | `46.21% <ø> (+0.84%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goharbor#carryforward-flags-in-the-pull-request-comment) to find out more. [see 491 files with indirect coverage changes](https://app.codecov.io/gh/goharbor/harbor/pull/21215/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goharbor)