search

goharbor / website

Source for the main Harbor website
https://goharbor.io
Apache License 2.0
33 stars 170 forks source link

Chart immutability implementation missing #342

Open miloslavkrisko opened 2 years ago

miloslavkrisko commented 2 years ago

This is more like an improvement request then an issue. Currently on Helm chart section there is no way how to implement an Chart immutability the same way as it is possible for the repositories.

Use Case is following: Let's say you have an application with Helm chart version 1.4.0 and app Version 1.4.0. The developer prepares the changes for 1.4.1 but accidently push it without version increase as the version is taken from the package.json to have it exactly mapped.

In this case it will happen that the version 1.4.0 is no longer true and get's overwritten. (I know it does not cause an issue untill helm repo update command is run, but still it is not a safe approach.

OrlinVasilev commented 2 years ago

Hi @miloslavkrisko - I suppose that's more issue to be resolved on the chart-museum side ?

miloslavkrisko commented 2 years ago

Hi @OrlinVasilev tbh i wasn't 100% if that's think which should be resolved on chart-museum side or within harbor side.

As i can imagine that on chart-museum there can be some variable or something which could enable this behaviour, but at the same time it can be part of harbor where if the toggle is setup for the project then the script would call somethink like: helm search repo | grep | grep | wc -l != (0/1) -> i am not sure if that will return 0 or 1 as counted the command itself and based on that it would throw an error.

But if you think it is more on chart-museum side i can try to create a request on their end :)

Also sorry for late reply, but i was on vacation in nature with no laptop to disconnect from modern world :)