gohome1984 / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

add Tell method to Minidump class #224

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Minidump has a SeekSet method, but no Tell method, so you can't currently
seek back to a spot for which you don't already have an absolute offset. 
The x86_64 code could use this, since its MinidumpContext doesn't have a
leading context_flags, so we have to read the entire context in to make
sure it's an x86_64 context, but we could fail here if there's another CPU
context of the same size, so we should really seek back and fall through.

Original issue reported on code.google.com by ted.mielczarek on 31 Oct 2007 at 12:14

GoogleCodeExporter commented 9 years ago
Simple patch.

Original comment by ted.mielczarek on 2 Dec 2007 at 3:43

Attachments:

GoogleCodeExporter commented 9 years ago
Checked in at revision 235.

Original comment by ted.mielczarek on 4 Dec 2007 at 8:41