search

gohome1984 / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

SystemInfo declared forward as class, but the real declaration is as struct - this makes MS tools choke #229

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The SystemInfo struct is declared forward as 'class SystemInfo' in a couple of 
places, but in the 
'real' declaration, it's declared as struct.
This causes the confusion with the MS compiler & linker, because apparently, 
the MS compiler 
uses different name mangling for classes and structs.
The obvious fix is to change the forward declarations to struct - or to change 
the 'real' 
declaration to class, but basically the forward declarations and the actual 
declaration should 
match.

I saw the problems with the VisualStudio 2005 tools, but IIRC, other versions 
of VisualStudio 
have the same name mangling differences from structs to classes...

The files affected are:

src/google_breakpad/processor/minidump_processor.h:class SystemInfo;
src/google_breakpad/processor/stackwalker.h:class SystemInfo;
src/google_breakpad/processor/symbol_supplier.h:class SystemInfo;

src/google_breakpad/processor/system_info.h:struct SystemInfo {

Original issue reported on code.google.com by j...@mac.com on 23 Nov 2007 at 3:32

GoogleCodeExporter commented 9 years ago 
Fixed in r937.

Original comment by thestig@chromium.org on 7 Feb 2014 at 10:58