Failed to build google-breakpad with the latest SunStudio12 express release

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Check out latest firefox trunk code from mozilla-central
2. Download and install the latest SunStudio12 express release from
http://developers.sun.com/sunstudio/downloads/express/index.jsp (currently
it's Nov 2008 build) (I use the x86 release).
3. Build firefox with it

What is the expected output? What do you see instead?

I got following error when building google-breakpad:

"/export/home/brian/moz-ws/community3/1203/mozilla-central/toolkit/crashreporter
/google-breakpad/src/common/solaris/../../google_breakpad/common/minidump_cpu_am
d64.h",
line 189: Warning: Types cannot be declared in anonymous union.
"/export/home/brian/moz-ws/community3/1203/mozilla-central/toolkit/crashreporter
/google-breakpad/src/common/solaris/dump_symbols.cc",
line 188: Error: Goto out bypasses a variable (or an exception) initialization.
"/export/home/brian/moz-ws/community3/1203/mozilla-central/toolkit/crashreporter
/google-breakpad/src/common/solaris/dump_symbols.cc",
line 182: Error: Goto out bypasses a variable (or an exception)
initialization. 

What version of the product are you using? On what operating system?
The error occurs on OpenSolaris.

Please provide any additional information below.
The attachment is the patch

Original issue reported on code.google.com by Eagle...@gmail.com on 4 Dec 2008 at 6:30

Attachments:

• crash-reporter.diff

[GoogleCodeExporter]

Issue 293 has been merged into this issue.

Original comment by neal...@gmail.com on 22 Feb 2009 at 8:26

[GoogleCodeExporter]

This is a different issue of Issue 293.

Original comment by ginnc...@gmail.com on 23 Feb 2009 at 3:54

[GoogleCodeExporter]

LGTM, committed(R=314)

Original comment by neal...@gmail.com on 23 Feb 2009 at 9:28

[GoogleCodeExporter]

Thanks for the patch

Original comment by neal...@gmail.com on 23 Feb 2009 at 9:30

[GoogleCodeExporter]

Original comment by neal...@gmail.com on 23 Feb 2009 at 9:30

• Changed state: Fixed