compile fix on ubuntu - Githubissues

Ubuntu comes with g++ (Ubuntu 4.3.2-1ubuntu12) 4.3.2, which has had some
cleanup in the includes, meaning that compilation fails:

g++ -g -O2 -o src/processor/minidump_dump src/processor/minidump_dump.o
src/processor/.libs/basic_code_modules.o src/processor/.libs/logging.o
src/processor/.libs/minidump.o src/processor/.libs/pathname_stripper.o  
depbase=`echo src/processor/minidump_stackwalk.o | sed
's|[^/]*$|.deps/&|;s|\.o$||'`;\
    g++ -DHAVE_CONFIG_H -I. -I./src  -I./src   -g -O2 -MT
src/processor/minidump_stackwalk.o -MD -MP -MF $depbase.Tpo -c -o
src/processor/minidump_stackwalk.o src/processor/minidump_stackwalk.cc &&\
    mv -f $depbase.Tpo $depbase.Po
In file included from /usr/include/c++/4.3/ext/hash_map:64,
                 from
./src/google_breakpad/processor/basic_source_line_resolver.h:45,
                 from src/processor/minidump_stackwalk.cc:40:
/usr/include/c++/4.3/backward/backward_warning.h:33:2: warning: #warning
This file includes at least one deprecated or antiquated header which may
be removed without further notice at a future date. Please use a
non-deprecated interface with equivalent functionality instead. For a
listing of replacement headers and interfaces, consult the file
backward_warning.h. To disable this warning use -Wno-deprecated.
src/processor/minidump_stackwalk.cc: In function ‘int main(int, char**)’:
src/processor/minidump_stackwalk.cc:483: error: ‘strcmp’ was not declared
in this scope

This patch fixes compilation:

Index: src/processor/minidump_stackwalk.cc
===================================================================
--- src/processor/minidump_stackwalk.cc (revision 310)
+++ src/processor/minidump_stackwalk.cc (working copy)
@@ -36,6 +36,7 @@
 #include <cstdlib>
 #include <string>
 #include <vector>
+#include <cstring>

 #include "google_breakpad/processor/basic_source_line_resolver.h"
 #include "google_breakpad/processor/call_stack.h"
Original issue reported on code.google.com by vur...@gmail.com on 17 Feb 2009 at 10:11
gohome1984 / google-breakpad

compile fix on ubuntu #291
