Compile Fix on Fedora 10

[GoogleCodeExporter]

Current Version:

[edmanm@kore symupload]$ svn info
Path: .
URL: http://google-breakpad.googlecode.com/svn/trunk/src/tools/linux/symupload
Repository Root: http://google-breakpad.googlecode.com/svn
Repository UUID: 4c0a9323-5329-0410-9bdc-e9ce6186880e
Revision: 345
Node Kind: directory
Schedule: normal
Last Changed Author: mmentovai
Last Changed Rev: 255
Last Changed Date: 2008-04-07 17:50:57 -0400 (Mon, 07 Apr 2008)

Build Errors:

[edmanm@kore symupload]$ make minidump_upload
g++ -gstabs -I../../.. -Wall -D_REENTRANT   -c -o minidump_upload.o
minidump_upload.cc
minidump_upload.cc: In function ‘void SetupOptions(int, const char**,
Options*)’:
minidump_upload.cc:123: error: ‘exit’ was not declared in this scope
minidump_upload.cc:131: error: ‘exit’ was not declared in this scope
make: *** [minidump_upload.o] Error 1
[edmanm@kore symupload]$ make sym_upload
g++ -gstabs -I../../.. -Wall -D_REENTRANT   -c -o sym_upload.o sym_upload.cc
sym_upload.cc: In function ‘void SetupOptions(int, const char**, Options*)’:
sym_upload.cc:195: error: ‘exit’ was not declared in this scope
sym_upload.cc:203: error: ‘exit’ was not declared in this scope
make: *** [sym_upload.o] Error 1

Patch (also attached):

[edmanm@kore symupload]$ svn di
Index: sym_upload.cc
===================================================================
--- sym_upload.cc   (revision 345)
+++ sym_upload.cc   (working copy)
@@ -40,6 +40,7 @@
 //  symbol_file: the contents of the breakpad-format symbol file

 #include <unistd.h>
+#include <stdlib.h>

 #include <cstdio>
 #include <cassert>
Index: minidump_upload.cc
===================================================================
--- minidump_upload.cc  (revision 345)
+++ minidump_upload.cc  (working copy)
@@ -34,6 +34,7 @@
 //  symbol_file: the breakpad format symbol file

 #include <unistd.h>
+#include <stdlib.h>

 #include <string>

Original issue reported on code.google.com by edm...@gmail.com on 1 Jun 2009 at 9:03

• Merged into: #300

Attachments:

• fc10-build-fix.patch

[GoogleCodeExporter]

Oops. Seems to be a duplicate of Issue #300. Didn't see that one the first time 
through.

Original comment by edm...@gmail.com on 1 Jun 2009 at 9:05

[GoogleCodeExporter]

Yeah, the code needs <cstdlib> and <cstring>, as issue #300's patch does, not 
the C
headers.

Original comment by jimbla...@gmail.com on 2 Jun 2009 at 2:32

[GoogleCodeExporter]

Original comment by ted.mielczarek on 3 Dec 2009 at 4:26

• Changed state: Duplicate