search

gohome1984 / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Mac: catch_exception_raise() symbol must always be visible #345

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Background: crbug.com/22659

When handling an exception, the exc_server() in the system library calls 
through to internal_catch_exception_raise() located at 
libsyscall/mach/exc_catcher.c in the xnu code tree.

internal_catch_exception_raise preforms a lookup for a userspace function 
with the name catch_exception_raise() and if no such symbol exists it calls 
abort().

Breakpad's version of catch_exception_raise needs to be annotated with  
__attribute__((visibility("default"))) to make sure it's visible to dlsym().

Original issue reported on code.google.com by jeremy@chromium.org on 11 Nov 2009 at 1:34

GoogleCodeExporter commented 9 years ago 
Patch at: http://breakpad.appspot.com/37001

Original comment by jeremy@chromium.org on 11 Nov 2009 at 1:38

GoogleCodeExporter commented 9 years ago 
Patch is checked in as r428 - please close this issue.

Original comment by jeremy@chromium.org on 12 Nov 2009 at 5:52

GoogleCodeExporter commented 9 years ago

Original comment by neal...@gmail.com on 12 Nov 2009 at 8:48