search

gohqingkhang / pe

0 stars 0 forks source link

Unable to reassign product #6

Open gohqingkhang opened 1 week ago

gohqingkhang commented 1 week ago

image.png

steps to repreduce: assign pr/Coca Cola Can 330ml su/Dairy Delights image.png

need to run command "assign pr/Coca Cola Can 330ml su/Dairy Delights", another time to be able to unassign, else cannot unassign

unassign pr/Coca Cola Can 330ml image.png

image.png

expected: allowed to reassign same supplier

actual: error message to show already assigned

nus-pe-bot commented 1 week ago

Team's Response

Same bug as #3710.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to unassign products

image.png

Prerequisites:

  1. Have a supplier John Doe

Steps to reproduce:

  1. add_product n/b stk/100 min/10 max/500 su/John Doe t/new t/featured
  2. unassign pr/b
  3. assign pr/b su/John Doe
  4. unassign pr/b

[original: nus-cs2103-AY2425S1/pe-interim#3263] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

With reference to the definition of severity.Medium and severity.High:

image.png

Functionality Impacted: The unassign command does not work as intended, preventing users from directly removing the relationship between a product and a supplier.

Workaround Available: Users can delete the product, breaking the relationship with the supplier, and then add the product back. While this is less convenient, it achieves the same outcome.

While the inability to unassign directly causes inconvenience, the existence of a viable workaround (deleting and re-adding the product) ensures that the product is not rendered unusable. The workaround is a few extra steps but does not block users from achieving their goals.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Fundamentally the bug I tested and the bug that the developer team chose as a duplicate are two different bugs in the code.

The bug that the developer team chose as a duplicate is a bug due to assignment of a product to a supplier. As explained in this issue: https://github.com/gohqingkhang/pe/issues/9 The bug has to do with the adding the product to the supplier's productList before updating the product's supplierName.

However, the bug that I tested is due to another issue and solving the above bug does not resolve the one I tested. I had circumvented the bug (chosen by the developer team) by calling the assignment twice, as shown above in the steps to reproduce. After which, I was able to call the command unassign to unassign the product to the supplier (which also shows that the initial assignment was successful). My next step was the call the assign command again. Which, at this time causes an error. Thus, I could also tell that this was due to an error in the unassignment of the product to the supplier in the code.

As such, there is a stark difference between the bug chosen by the developer team and the bug I had tested in that one was a problem in assignment, whereas the other was a problem in unassignment.

## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]