gohugoio / hugo

The world’s fastest framework for building websites.
https://gohugo.io
Apache License 2.0
75.15k stars 7.48k forks source link

Remove the Speaker Deck shortcode from Hugo #4830

Closed onedrawingperday closed 6 years ago

onedrawingperday commented 6 years ago

Related: #4764

tldr: Nobody is using Speaker Deck because the default internal shortcode does not create a presentation embed for all..

In my investigation of the Speaker Deck shortcode I discovered that the original author of this shortcode has included the following:

<script async class='speakerdeck-embed' data-id='{{ index .Params 0 }}' data-ratio='1.33333333333333' src='//speakerdeck.com/assets/embed.js'></script>

For example here is the script from another presentation

<script async class="speakerdeck-embed" data-id="510aed10c64e463c907215787e643f7e" data-ratio="1.77777777777778" src="//speakerdeck.com/assets/embed.js"></script>

Note that in the above the data-ratio is 1.77777777777778 because this presentation has an aspect ratio of 16:9.

The current shortcode is broken

To reproduce on your own please enter the data-id of the second presentation in one of your Hugo projects: {{< speakerdeck 510aed10c64e463c907215787e643f7e >}}

Absolutely nothing will be rendered.

I vote for the removal of this shortcode from Hugo. If anyone was really using it there would have been open issues about it by now.

CC @bep @digitalcraftsman @kaushalmodi @regisphilibert @budparr @moorereason @it-gro @rdwatters and everyone else

onedrawingperday commented 6 years ago

This has been reported in the Forum some time ago.

https://discourse.gohugo.io/t/speakerdeck-shortcode-leaves-blank-space/3191/

The user asked help about the shortcode's white space.

But on my end I get nothing rendered for presentations with 16:9 aspect ratio.

Also note that Speaker Deck is no longer associated with GitHub and things have changed a bit with this service since yesterday.

kaushalmodi commented 6 years ago

+1 for removal of this shortcode

bep commented 6 years ago

OK, @onedrawingperday -- can you remove it and also remove the relevant documentation from this repo?

Also, to make sure we mention it in bold in release notes: Put a line in here: #4831

onedrawingperday commented 6 years ago

Ok @bep I can remove this. I will send the Pull Request tomorrow.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.