search

gohugoio / hugoBasicExample

MIT License
281 stars 281 forks source link

Added french posts translation for testing internationalization (i18n) #11

Closed remyj38 closed 5 years ago

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

Xzya commented 6 years ago

Any update on this? It would be of great help for testing new themes.

Thanks!

ghost commented 6 years ago

For sites using i18n having a basic example which adds relevant config seems useful. In #15 there is also an opportunity to add config to enhance the presentation of many sites—but it's opinionated and, as in the case of this pull, the config updates add a level of subjectivity to what the concept of a “basic” theme demo really means.

Having a standardized method for enabling themes to pass Hugo (but not theme) specific configuration options along with themes and have those settings variadically control the build output without dropping in a kitchen sink of params will help highlight themes which are built to function without a special, theme-specific set of params.

onedrawingperday commented 5 years ago

@digitalcraftsman

This oldish Pull Request looks very good and I suggest that you merge it since it would extend the HugoBasicExample for supporting i18, (in this case English and French).

digitalcraftsman commented 5 years ago

Having an example to showcase the i18n capabilities is a good extension. However, from a long-term perspective it can happen that some parts of the documentation (no matter of language) is outdated because features changed or have been deprecated.

The English version of this content has been written ages ago but still holds true after browsing some documents. @onedrawingperday would you leave the content as it is or would you rather replace it with some more neutral (meaning time-independent) content?

This are just my 2 cents. However, this translation is a nice addition and most of the content will still hold true for a while.

onedrawingperday commented 5 years ago

The English version of this content has been written ages ago but still holds true after browsing some documents. @onedrawingperday would you leave the content as it is or would you rather replace it with some more neutral (meaning time-independent) content?

@digitalcraftsman I agree with you. The content needs to change in this repo to something more neutral. This will be addressed in a coming PR.