search

gohugoio / hugoBasicExample

MIT License
281 stars 281 forks source link

Un-nest the <kbd> example #71

Closed jfoshee closed 7 months ago

jfoshee commented 3 years ago

Nesting <kbd> within <kbd> would be very unusual. The point of this page is to demonstrate commonly used styles. In some cases the nesting causes the individual "keys" to lose their distinction.

coliff commented 3 years ago

agree with @davidsneighbour - I approved the PR, but then took a look at it and decided to 'unapprove' it. In this context it looks correct: image

jfoshee commented 3 years ago

I appreciate the Mozilla docs. I had not seen those semantics before.

However, how many Hugo themes include style rules to render nested <kbd> correctly? I think I've only seen one. The point of this page is to demonstrate common styles. Would you argue that nested <kbd> is more common than un-nested? If it's a quibble, how about we just include examples of both?