Closed irkode closed 3 months ago
Thank you for your suggestion.
Perhaps there's a language barrier here, but when I read this it's scary and implies that it's dangerous. I'm not going to merge this as-is, and will review and make suggestions when I have time.
In the future, when a maintainer suggests an alternate approach, please give it ample consideration before doing what you want to do.
I'm fine with your decision. To not merge and rethink / rewrite.
I promise I did an ample consideration (had to lookup that in a dictionary). And explained my different opinion in the PR.
Didn't want to be scaring. Maybe something in between 'safe' and 'dangerous'.
referencing https://discourse.gohugo.io/t/content-adapter-examples-and-performance/49830/20 ff I'm pleased to provide a PR
So here's my suggestion that will
Especially with a varying audience it's important to set a point. The unexperienced users just see the performance gain and they'll just do what suggested. And keep in mind: you are the persons of trust for your users.
I would skip the link to Microsoft. It's better to have an emphasized statement about impacts here and not in a link to the documentation (the normal user will not read because it's already described ;-)