search

gohugoio / hugoDocs

The source for https://gohugo.io/
Apache License 2.0
1.05k stars 1.48k forks source link

Change twitter.com to x.com #2590

Closed coliff closed 3 months ago

coliff commented 3 months ago

Saves a HTTP redirect and is less characters :-)

Note: Probably makes sense to think about renaming the twitter username param in Hugo itself (to x or x-twitter) (https://gohugo.io/templates/embedded/#twitter-cards)...

jmooring commented 3 months ago

This still includes changes (whitespace differences) to _vendor/github.com/gohugoio/gohugoioTheme/layouts/partials/site-footer.html.

coliff commented 3 months ago

ugh, added a space back and squashed my commits but still shows a change there. Shouldn't we just remove the trailing space?

jmooring commented 3 months ago

If you want to remove the trailing space do it in the theme repo. PRs to this repo shouldn't touch the vendored theme.