gohugoio / hugoDocs

The source for https://gohugo.io/
Apache License 2.0
1.03k stars 1.47k forks source link

Docs section "Conditional loading of Disqus comments" is redundant and dangerously misleading. Can be safely removed. #2630

Closed bryndin closed 1 month ago

bryndin commented 1 month ago

This section of docs is redundant, misleading, and should be removed:
https://gohugo.io/templates/embedded/?search-input=disqusShortname#conditional-loading-of-disqus-comments

Not only is this logic already present in the template, and thus redundant https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/templates/disqus.html

it doesn't have the safety checks, e.g. {{ if .Site.Config.Services.Disqus.Shortname }} that are present in the template.

What version of Hugo are you using (hugo version)?

master

Does this issue reproduce with the latest release?

yes