gohugoio / hugoThemes

A curated directory of Hugo themes
https://themes.gohugo.io/
MIT License
1.77k stars 244 forks source link

New Theme: AllinOne #435

Closed orianna-zzo closed 6 years ago

orianna-zzo commented 6 years ago

Theme submission

Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.

Link to my theme repository: https://github.com/orianna-zzo/AllinOne

Link to my theme demo: https://orianna-zzo.github.io/AllinOne-html/

I made sure that...

Feel free to ask questions. We're glad to help.

digitalcraftsman commented 6 years ago

Hello @orianna-zzo,

thank you for submitting this theme :+1:

While checking your theme with the build script for the Hugo theme site I got an error message due to the definition of the variable demo in theme.toml. This variable name is kind of reserved because the build script copies the content of the theme.toml and adds a few other meta data including a variable called demo. The build script throws the error because demo is defined twice. Just rename demo to something like customdemo in the theme.toml in order to fix this issue.

Otherwise your theme looks ready to be added.

orianna-zzo commented 6 years ago

Thanks @digitalcraftsman. I've fixed this. Please check again 😄

digitalcraftsman commented 6 years ago

Great. Your theme looks fine now and should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.