New Theme: Robotico

[wileymc]

Theme submission

Link to my theme repository: https://github.com/wileybaba/hugo-theme-robotico

I made sure that...

• [x] an open source license has been added to LICENSE.md
• [x] the repository contains a good README.md describing my theme
• [x] all metadata have been added to theme.toml
• [x] screenshots have been added in the images/ folder with the required dimensions
• [x] in case I'm using a customized demo via the exampleSite folder that
  • [x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
  • [x] the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
• [x] I tested my theme against the gohugoio/HugoBasicExample
  • [x] I've checked the developer tools' console in my browser for error messages
• [x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

I tested with the HugoBasicExample and with the GoHugo site build and my demo seemed to work as intended. Let me know if I'm missing anything, thanks!

[onedrawingperday]

Hi @wileybaba and thanks for your theme submission.

On first glance you need to rectify your theme's screenshots, because your theme is called Hugo Robotico Theme and yet in your images the title reads as Hugo-Minimo-Theme (which is an existing Hugo theme).

• Please change the title in your screenshots to avoid confusing users.

• Also in line 4 of your theme.toml you need to enter the URL of your theme's GitHub repository.

• And finally in line 10 of your theme.toml please lowercase your domain's extension i.e. .website

Once you do the above please let me know so that I can review your theme further.

Thanks!

P.S. Cool ceramic pots on your personal website by the way! 👍

[wileymc]

Hi there,

Thank you for the initial theme review. I've made the changes you ask for above. Let me know if anything else needs to be fixed, and thanks for the kind words about my pots!

[onedrawingperday]

@wileybaba

Your theme's Example Site fails to render both when I execute the Hugo Themes Site Build Script and when I run hugo server at the root of the /ExampleSite/ folder.

I am getting the following console error: Error: Error building site: "/hugoThemes/hugo-theme-robotico/exampleSite/content/about.md:1:4": EOF looking for end TOML front matter delimiter

You need to have proper line breaks in the front matter of about.md, right now everything is in a single line.

Thanks.

[onedrawingperday]

Also @wileybaba you need to fix the following:

• You need to serve https://wileys.website/img/Robobrand.png as an asset from within your ExampleSite's static folder. Also please resize this image into an appropriate resolution for the web. Right now it is 7440 x 9039 pixels and that is way too big.

Also there are multiple issues with your baseof.html:

• In line 13 why have you set the og:locale meta property to nn_NO? Not everyone is from Norway. I think that you need to make this into a parameter that the user can set in the config.toml and reference that parameter for setting this meta property.

• In lines 18 and 25 you have set content="{{ .Site.BaseURL }}{{ .Params.meta_img | default .Site.Params.logofile }}" /> and when testing your ExampleSite this is outputted as content="http://localhost:1313/theme/hugo-theme-robotico/https://wileys.website/img/Robobrand.png" /> You need to remove {{ .Site.BaseURL }}. As I said above you need to serve this image as an asset of your theme and not from an external URL so you need to use the absURL function to create an absolute URL for this image in your template. Also have a look at the Common Permalink Issues in the repository's README for further guidance about constructing a URL that will work on the Hugo Theme's Site.

• Please enter a description parameter in your ExampleSite's config because right now all description meta properties are rendered empty.

Furthermore:

• You have included jQuery multiple times in your templates. You need to remove it from line 18 of your list.html because it's already included in your baseof.html.

Please do the above and let me know so that I can review your theme further.

[wileymc]

Thanks @onedrawingperday,

I've just pushed fixes to the above. I deleted the og:local meta property from baseof.html .

Let me know if more attention is needed, thank you.

[onedrawingperday]

Thanks for making the changes @wileybaba

I have noticed the following:

• In your /portfolio/list.html the lightbox no longer works because after removing the second instance of jQuery -as I instructed above- the script that fires the lightbox is placed before the link to jQuery and as a result it doesn't execute.

To fix this ordering issue please do the following:

• In line 66 of your baseof.html include a new block like so:

  {{ block "lightbox" . }}{{ end }}

• Then in your /portfolio/list.html wrap the script in the lightbox block and move it at the bottom of your template after {{ partial "footer" }}{{ end }} like so:

  {{ define "lightbox" }}
  <script>
  $(document).on("click", '[data-toggle="lightbox"]', function(event) {
    event.preventDefault();
    $(this).ekkoLightbox({
      alwaysShowClose: true
    });
  });
  </script>
  {{ end }}

  It is important that you place the new lightbox block outside the main block because if you don't there will be an ERROR that will prevent your Example Site from rendering.

Finally in your theme.toml I have noticed that you have not included a link to your theme's LICENCE

• Please add the following: licenselink = "https://github.com/wileybaba/hugo-theme-robotico/blob/master/LICENSE.md"

Again once you do the above, let me know.

Thanks.

EDIT Also I just noticed that in your template you have forgotten the dot in {{ partial "footer" }}. Please make sure that all partials in your templates have the dot. Like so: {{ partial "footer" . }}. Also see the Doc

[wileymc]

Great spot on that missing dot. I've just pushed the changes you requested and testing looks good on my machine.

[onedrawingperday]

@wileybaba Your theme's demo is looking good on my end now. 👍

However you didn't add the licencelink in your theme.toml licenselink = "https://github.com/wileybaba/hugo-theme-robotico/blob/master/LICENSE.md"

Please add it and let me know:

[wileymc]

Should be good to go now, thanks for walking me through the bugs!

[onedrawingperday]

Everything is OK now @wileybaba

@digitalcraftsman This theme is ready to added to the website. It is a stripped down fork of the alaGeek theme with an added portfolio/light-box gallery for artists/photographers to display their work.

[digitalcraftsman]

Hello Wiley,

thank you for sharing this theme with the Hugo community :+1:

Before adding your theme please set a minimum Hugo version in your theme.toml like here. Furthermore, it's not necessary to add a themes folder inside exampleSite. The build script will automatically take care of that. Hence, please remove said directory.

[wileymc]

Hi @digitalcraftsman,

I've added the min_version and removed the theme directory from the repo. Let me know if anything else is necessary, thank you!

[digitalcraftsman]

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

[wileymc]

Sweet sounds good. Keep up the killer work on Hugo, one of my favorite GO projects out there!

El nov. 20, 2018, a la(s) 13:31, digitalcraftsman notifications@github.com escribió:

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.