gohugoio / hugoThemes

A curated directory of Hugo themes
https://themes.gohugo.io/
MIT License
1.77k stars 245 forks source link

New theme submission: Onepress #529

Closed jeremyikwuje closed 5 years ago

jeremyikwuje commented 5 years ago

Hi team Hugo,

Created a new theme called Onepress

Repo: https://github.com/ijsucceed/onepress

Thank you,

onedrawingperday commented 5 years ago

Hello @ijsucceed

Thank you for the theme submission. I had a quick look and I noticed that your theme's screenshots contain promotions to third party services. I'm afraid that promotions are not allowed on the Hugo Themes website, as stated in the repository's README the content of the example site needs to be as neutral as possible.

So please remove any non Hugo related promotional content from your theme's Example Site and the screenshots and please let me know so that I can review your theme further.

Thank you.

jeremyikwuje commented 5 years ago

Thank you for the information.

I just commit another screenshot and thumbnail.

onedrawingperday commented 5 years ago

@ijsucceed Thank you for changing the screenshots.

However you also need to remove the Paystack logo and the title above it.

From what I’ve seen your Example Site’s Content feautures neutral posts. It would be best if you took screenshots of the actual Example Site not your personal blog (that uses your theme).

Please do the above and let me know.

onedrawingperday commented 5 years ago

@ijsucceed

I tested your theme with the Hugo Themes Site build script and there are more issues with your submission that you need to fix:

  1. Please change line 1 of config.toml to: baseURL = "https://example.com" (see note n.6 in the Adding a theme to the list section of the README.

  2. Remove line 5 from config.toml (there is no need to specify this file as Hugo reads it by default, this parameter is meant for custom config files)

  3. Remove your Google Analytics tracking ID from line 8 and your Disqus Shortname from line 10 of config.toml Tracking is not accepted on the Hugo website, please leave the googleAnalytics and disqusShortname parameters blank.

  4. Remove the first forward slash from the relative URLs in lines 18-20 of config.toml. As stated in the Common Permalink Issues section of the README a forward slash / in the beginning of a URL will point to the host root and since your theme's demo will be published in a subdirectory of the themes website Hugo will not generate the correct URL for the images that you have entered in these parameters.

  5. For the same reason as above remove the first forward slash from the featuredImage parameter from this content file and this one.

Please look into the above and let me know so that I can post more fixes about the issues that are present in your theme.

If you have any questions do not hesitate to ask.

jeremyikwuje commented 5 years ago

Thank you very much.

I have made those changes.

This is my first theme on Hugo.

More errors are welcome.

I already learning from the errors you spot.

onedrawingperday commented 5 years ago

@ijsucceed Thank you for issuing the fixes and no worries, we all were beginners in Hugo at some point.

Now can you please look into the following issues:

Please do the above and let me know.

Thanks

jeremyikwuje commented 5 years ago

Done!

Please do let me know on any change.

Thanks.

onedrawingperday commented 5 years ago

@ijsucceed

Thanks for making the above changes.

Can you please look into the following:

jeremyikwuje commented 5 years ago

Wow! I love the way you suggest I fix the subscription problem.

This will allow any user to know what to do easily.

I fixed it.

Thank you.

onedrawingperday commented 5 years ago

@ijsucceed Everything is looking good on my end now! 👍

@digitalcraftsman This theme is ready to be added to the Hugo Themes website.

digitalcraftsman commented 5 years ago

@ijsucceed your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.