Closed jeremyikwuje closed 5 years ago
Hello @ijsucceed
Thank you for the theme submission. I had a quick look and I noticed that your theme's screenshots contain promotions to third party services. I'm afraid that promotions are not allowed on the Hugo Themes website, as stated in the repository's README the content of the example site needs to be as neutral as possible.
So please remove any non Hugo related promotional content from your theme's Example Site and the screenshots and please let me know so that I can review your theme further.
Thank you.
Thank you for the information.
I just commit another screenshot and thumbnail.
@ijsucceed Thank you for changing the screenshots.
However you also need to remove the Paystack logo and the title above it.
From what I’ve seen your Example Site’s Content feautures neutral posts. It would be best if you took screenshots of the actual Example Site not your personal blog (that uses your theme).
Please do the above and let me know.
@ijsucceed
I tested your theme with the Hugo Themes Site build script and there are more issues with your submission that you need to fix:
Please change line 1 of config.toml
to: baseURL = "https://example.com"
(see note n.6 in the Adding a theme to the list section of the README.
Remove line 5 from config.toml
(there is no need to specify this file as Hugo reads it by default, this parameter is meant for custom config files)
Remove your Google Analytics tracking ID from line 8 and your Disqus Shortname from line 10 of config.toml
Tracking is not accepted on the Hugo website, please leave the googleAnalytics
and disqusShortname
parameters blank.
Remove the first forward slash from the relative URLs in lines 18-20 of config.toml
. As stated in the Common Permalink Issues section of the README a forward slash /
in the beginning of a URL
will point to the host root and since your theme's demo will be published in a subdirectory of the themes website Hugo will not generate the correct URL for the images that you have entered in these parameters.
For the same reason as above remove the first forward slash from the featuredImage
parameter from this content file and this one.
Please look into the above and let me know so that I can post more fixes about the issues that are present in your theme.
If you have any questions do not hesitate to ask.
Thank you very much.
I have made those changes.
This is my first theme on Hugo.
More errors are welcome.
I already learning from the errors you spot.
@ijsucceed Thank you for issuing the fixes and no worries, we all were beginners in Hugo at some point.
Now can you please look into the following issues:
You need to provide a description
of your theme in line 7 of theme.toml
. Also you need to fill out the tags
parameter in line 9 and the features
parameter in line 10. Look here a for a sample theme.toml
that has all the required parameters filled out.
Please fill out your name and website in lines 14-15 of your theme.toml
and also delete lines 17-21 since these parameters are blank.
In partials/post-list.html
please replace instances of .URL
with either .Permalink
or .RelPermalink
(see Page Variables for more info).
You should also do the same as above in partials/latest-posts.html
(although from what I've seen you don't use this partial in your theme's templates and I'm not sure why you have it included.
In your partials/brand.html
you need to provide the means to your theme's user to have a valid alt
attribute for the logo image. I suggest that you use the following: alt="{{ .Site.Params.Title }}"
Finally in your partials/nav.html
from what I've seen Tiny Letter does not support RSS Feeds, so it doesn't really make sense that you have this link wrapped within .Site.Params.enableRSS
. You may switch to Mailchimp that has this functionality (along with a generous free plan), but in any case you need to turn the username or the link to the subscribe form into a parameter of your Example Site's config and reference that in your theme's templates so that the users can customize this link easily.
Please do the above and let me know.
Thanks
Done!
Please do let me know on any change.
Thanks.
@ijsucceed
Thanks for making the above changes.
Can you please look into the following:
In your partials/nav.html
you haven't closed the <ul>
tag. Please insert </ul>
at the end of the file.
Thanks for fixing the Subscribe link. However we usually try to have working menu links in theme demos and now this link throws a 404. I think that the way to fix this would be to add a section in your theme's README with user instructions about the Subscribe link and then link to that section from the Example Site by using for example this link in the config:
subscribeLink = "https://github.com/ijsucceed/onepress/blob/master/README.md#subscribe-link"
You could write something like the following in the Subscribe Link section:
## Subscribe link
Use the parameter `subscribeLink` to create a link to a page (internal or external) that contains your email subscription form.
The above text is indicative. Feel free to write this note about the subscribeLink
as you see best.
Wow! I love the way you suggest I fix the subscription problem.
This will allow any user to know what to do easily.
I fixed it.
Thank you.
@ijsucceed Everything is looking good on my end now! 👍
@digitalcraftsman This theme is ready to be added to the Hugo Themes website.
@ijsucceed your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.
Hi team Hugo,
Created a new theme called Onepress
Repo: https://github.com/ijsucceed/onepress
Thank you,