search

gohugoio / hugoThemes

A curated directory of Hugo themes
https://themes.gohugo.io/
MIT License
1.77k stars 245 forks source link

Theme submission: Edidor-- a theme looks like an editor #635

Closed sfengyuan closed 5 years ago

sfengyuan commented 5 years ago

Hi. Repo: https://github.com/jacobsun/edidor Demo: https://ziox.xyz Thanks for review.

digitalcraftsman commented 5 years ago

Hello @jacobsun,

thank you for sharing this theme with the Hugo community. While reviewing your theme I noticed a few issues:

Please make sure that the thumbnail and screenshot in the images folder have the right dimensions. You can find them in the README.

When opening the demo I only see a dark grey screen. This happens because the <div id="cloak"></div> covers the entire page. Does this div get removed by ziox.js? The script throws the following error message in the console:

ziox.js:91:1 - TypeError: document.querySelector(...) is null

Furthermore, I'm suggesting the use of the .Site.Params.mainSections variable to offer users more flexiblity over the content types that are displayed on the homepage. Right now, the "posts" content type is hard-coded.

When linking the homepage via the logo please make use of .Site.BaseURL over here. If a website is hosted in a sub-directory like www.example.com/blog and you hard-code / then the /blog/ part will falsely be omitted. Theme demos are also hosted in a sub directory and users would be redirected the homepage of the Hugo theme gallery, not the homapge of your theme.

sfengyuan commented 5 years ago

Hi!

Thank you.

digitalcraftsman commented 5 years ago

I noticed that screenshot.png and tn.png are located in edidor/exampleSite/static/images. But the images folder with screenshot.png and tn.png belongs into the root directory of your theme. Otherwise the build script for the Hugo theme site is unable to find them and omits the generation of your theme's demo.

sfengyuan commented 5 years ago

That's a stupid mistake. Corrected, and I also edit the exampleSite config to make it looks like a demo.

digitalcraftsman commented 5 years ago

Great. Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

sfengyuan commented 5 years ago

Wow, that's a surprise, thanks. : )