Broken Themes on the Hugo Showcase

digitalcraftsman commented 4 years ago

This issue is meant for author notification and not discussion.

The following themes broke for various reasons and need to be fixed or will be removed. Theme authors should know how to fix their themes based on the errors logs below.

If theme authors do not know how to fix their themes then they should ask at the dedicated Hugo Support Forum: https://discourse.gohugo.io/

When a fix is issued then authors should ping me in the corresponding commit with @digitalcraftsman or respond to this thread, so that I get notified. Themes will be updated automatically every three days.

digitalcraftsman commented 4 years ago

The following themes have been removed:

hugo-bare-min-theme cc @kaushalmodi
hugo-now-ui cc: @cboettig
engimo cc @achary

MunifTanjim commented 4 years ago

Minimo should be fixed: https://github.com/MunifTanjim/minimo/commit/594144f784e5e0e570434056a369f34e6257b7be 🤔 Is it still broken?

digitalcraftsman commented 4 years ago

Thank you for the fix Munif. I've updated the themes and Minimo's demo is running fine again.

kaushalmodi commented 4 years ago

@digitalcraftsman I appreciate your work on keeping the Hugo themes clean. Thanks for this notification.

so1ve commented 4 years ago

Hello, isn't hugo-theme-tony fixed in https://github.com/ThemeTony/hugo-theme-tony/commit/e01e218e56dfa5a003dd6bee89a020c0fe437e14? 😢

digitalcraftsman commented 4 years ago

@FFRaycoder let's continue this discussion at https://github.com/ThemeTony/hugo-theme-tony/issues/7

Shadow53 commented 4 years ago

Feel free to remove Midnight for the time being. I'm in the middle of a major refactoring and will resubmit once that's done.

kc0bfv commented 4 years ago

Thank you, haven't seen this bug before. Will check it out.

On Fri, Jul 31, 2020, 06:03 digitalcraftsman notifications@github.com wrote:

This issue is meant for author notification and not discussion.

The following themes broke for various reasons and need to be fixed or will be removed. Theme authors should know how to fix their themes based on the errors logs below.

If theme authors do not know how to fix their themes then they should ask at the dedicated Hugo Support Forum: https://discourse.gohugo.io/

When a fix is issued then authors should ping me in the corresponding commit with @digitalcraftsman https://github.com/digitalcraftsman or respond to this thread, so that I get notified. Themes will be updated automatically https://github.com/gohugoio/hugoThemes#theme-updates every three days.

ticky-tacky-dark - cc: @kc0bfv https://github.com/kc0bfv

Listed since July 31st

ticky_tacky_dark is whitelisted

12:53:44 PM: Building site for theme ticky_tacky_dark using its own exampleSite to ../themeSite/static/theme/ticky_tacky_dark/

12:53:44 PM: fatal error:

12:53:44 PM: concurrent map read and map write

12:53:44 PM: goroutine 99 [running]:

12:53:44 PM: runtime.throw(0x1d52494, 0x21)

...

Reason: concurrent read and write access of a map during build. Due to the length of the stack trace please have a look at the build log https://app.netlify.com/sites/hugothemes/deploys/5f23f6d14febd6790c5a917e for the Hugo theme site.

pulp - cc: @koirand https://github.com/koirand

Listed since July 28th

ERROR 2020/07/28 14:39:22 You have configured output formats for 'taxonomy' in your site configuration. In Hugo 0.73.0 we fixed these to be what most people expect (taxonomy and term).

But this also means that your site configuration may not do what you expect. If it is correct, you can suppress this message by following the instructions below.

If you feel that this should not be logged as an ERROR, you can ignore it by adding this to your site config:

ignoreErrors = ["error-output-taxonomy"]

Building sites … WARN 2020/07/28 14:39:22 Markup type mmark is deprecated and will be removed in a future release. See https://gohugo.io//content-management/formats/#list-of-content-formats

academia-hugo - cc: @themefisher https://github.com/themefisher Listed since July 28th

Reason: the build script for www.themes.gohugo.io expects an example config file in exampleSite.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gohugoio/hugoThemes/issues/867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALGLJIJ6VNJD227X2MBQITR6KQIJANCNFSM4N4JG4XQ .

koirand commented 4 years ago

Thanks for the notification, I've fixed the broken theme.

panr commented 4 years ago

@digitalcraftsman hugo-theme-hello-friend and hugo-theme-terminal are fixed. The problem should disappear.

digitalcraftsman commented 4 years ago

Thank you Radek 👍

knadh commented 4 years ago

@digitalcraftsman unable to reproduce the issue on hugo-ink locally with v0.74.3 on Ubuntu.

$ hugo serve --themesDir ../.. -t hugo-ink

                   | EN  
-------------------+-----
  Pages            | 31  
  Paginator pages  |  1  
  Non-page files   |  0  
  Static files     |  5  
  Processed images |  0  
  Aliases          |  1  
  Sitemaps         |  1  
  Cleaned          |  0  

Built in 16 ms
Watching for changes in $PATH/hugo-ink/{archetypes,exampleSite,layouts,static}
Watching for config changes in $PATH/hugo-ink/exampleSite/config.toml
Environment: "development"
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at http://localhost:1313/ (bind address 127.0.0.1)
Press Ctrl+C to stop

digitalcraftsman commented 4 years ago

That's because the error only occurs with the default content for demos privided by https://github.com/gohugoio/hugoBasicExample. The ambiguity occured (here) because one of the default content files was tagged and categorized with themes.

I've removed the corresponding tag such that this ambiguity doesn't occur with https://github.com/gohugoio/hugoBasicExample. But be aware that this isn't fixing future instances (e.g. of your theme's users) in which such an ambiguity can't be resolved by Hugo.

Nonetheless, the demo runs fine now and I'll remove your theme from the list above.

capnfabs commented 3 years ago

Hi @digitalcraftsman, paperesque should be fixed as of this commit: https://github.com/capnfabs/paperesque/commit/d5861572846d6e0e61e574cd09c46a06efbbe61f

Thanks for the notification and please let me know if there are any additional issues.

digitalcraftsman commented 3 years ago

Thanks for you fix. In your theme repository I see a mainline and master branch. Your linked commit is present on the mainline branch, whereas the Hugo theme site uses the master branch as source for your theme's demo. Which of them should be used for the demo?

capnfabs commented 3 years ago

@digitalcraftsman The mainline branch is correct; I've since deleted the master branch to make it clearer. Note also that the mainline branch is the default on the repo, which might mean it works without changes? At least, the following works on my machine without changes to the hugoThemes repo:

 git clone git@github.com:gohugoio/hugoThemes.git
cd hugoThemes/_script
./reviewTheme.sh git@github.com:capnfabs/paperesque.git

Sorry for not being clear about this initially and thanks for your support!

digitalcraftsman commented 3 years ago

Changing the source branch for the theme demo isn't that difficult. Depending on your answer I had to make this change or not. Nonetheless, your theme has been updated and the demo is running again. I'll remove your theme from the first comment of this thread in a minute.

matsuyoshi30 commented 3 years ago

@digitalcraftsman Thanks for the notification and sorry for the delay. harbor should be fixed at matsuyoshi30/harbor@cae4c317bc10bf8490b1ba97ca3cbdf8741d014a. If it is still broken, please let me know!

digitalcraftsman commented 3 years ago

Thank you fixing the issue. Your theme has been updated and the demo is working again. I'll remove your theme from the first comment of this thread in a minute.

4ever9 commented 3 years ago

https://github.com/4ever9/less hugo(extended) caused this error. You should use npm i to install dependency.

@digitalcraftsman

digitalcraftsman commented 3 years ago

Hi @4ever9,

the demos on www.themes.gohugo.io are build with the "basic" version of Hugo (on purpose), thus stylesheets, JS files etc. would have to be prebuild and pushed to a theme's Git repository.

The workaround for cases, where a theme's couldn't be hosted on www.themes.gohugo.io (e.g. special theme requirements/dependencies), theme authors self-hosted the theme demo. Usually, they would link the demo using the homepage variable in theme.toml or add a link at the top of their theme's README. The themes are still listed on www.themes.gohugo.io though! The docsy theme is such a case.

Even if you decide aginst self-hosting, your theme would still be listed on www.themes.gohugo.io, just with the demo (button) disabled.

gohugoio / hugoThemes

Broken Themes on the Hugo Showcase #867

When a fix is issued then authors should ping me in the corresponding commit with @digitalcraftsman https://github.com/digitalcraftsman or respond to this thread, so that I get notified. Themes will be updated automatically https://github.com/gohugoio/hugoThemes#theme-updates every three days.

Reason: concurrent read and write access of a map during build. Due to the length of the stack trace please have a look at the build log https://app.netlify.com/sites/hugothemes/deploys/5f23f6d14febd6790c5a917e for the Hugo theme site.