search

gohugoio / hugoThemes

A curated directory of Hugo themes
https://themes.gohugo.io/
MIT License
1.77k stars 244 forks source link

Theme submission : TeXify #890

Closed queensferryme closed 4 years ago

queensferryme commented 4 years ago

Theme submission

Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. We strongly suggest that you test your theme with the Hugo Themes Build Script before submitting the theme for review. If a submission does not meet the criteria mentioned in the README it will be closed. You may re-submit once you fix the problems with your submission. However, please note that we have limited resources and can not provide help for general web development issues. For Hugo support questions please refer to the dedicated support forum.

Please tick the relevant boxes for your theme in the checklist below:

Link to my theme repository: https://github.com/queensferryme/hugo-theme-texify

I made sure that...

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. If a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.

New themes will usually be promoted on Hugo's official Twitter account. If you would like to be mentioned in the tweet please add your Twitter username to this submission.

Link to my Twitter account (optional): https://twitter.com/queensferryme

Feel free to ask questions. We're glad to help.

digitalcraftsman commented 4 years ago

Hello @queensferryme,

while browsing the repository of your Texify theme I noticed that it seems to be based on the hugotex. This is neither mentioned in README.md, theme.toml nor LICENSE.md.

You've to give proper credit to the original author in theme.toml. Use the original table and fill out all required fields:

# If porting an existing theme
[original]
    author = "Name of original author"
    homepage = "His/Her website"
    repo = "Link to source code of original theme"

The MIT used by the hugotex theme explicitly states that

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Meaning you have to keep the original unaltered copyright notice in all future distributions of the software. You can add yourself to this copyright notice of course.

queensferryme commented 4 years ago

Hi @digitalcraftsman, thanks for reviewing.

It's understandable that my theme TeXify would be mistaken as being ported from HugoTex. I admitted that parts of the interface design are inspired by HugoTex, and I decided to add a new acknowledgement section in my project's README.md out of your kind reminding.

However, according to the definition of software porting on Wikipedia, I don't believe that my projected should be deemed ported, as I have written all the codes from groud up by myself without referencing HugoTex. The interface design is also not exclusive either, I have been inspired by the following three projects (including HugoTex) with respects to design issues:

These are my humble opinions. I hope we could come to a compromising solution.

digitalcraftsman commented 4 years ago

Thank you for the clarification @queensferryme. Your theme is already live on Hugo's theme site and will be promoted soon on Hugo's official Twitter account.