search

gohugoio / hugoThemes

A curated directory of Hugo themes
https://themes.gohugo.io/
MIT License
1.77k stars 244 forks source link

Theme submission: Timeline #927

Closed s4n7h0 closed 4 years ago

s4n7h0 commented 4 years ago

Theme submission

Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. We strongly suggest that you test your theme with the Hugo Themes Build Script before submitting the theme for review. If a submission does not meet the criteria mentioned in the README it will be closed. You may re-submit once you fix the problems with your submission. However, please note that we have limited resources and can not provide help for general web development issues. For Hugo support questions please refer to the dedicated support forum.

Please tick the relevant boxes for your theme in the checklist below:

Link to my theme repository: https://github.com/s4n7h0/hugo-theme-timeline

I made sure that...

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. If a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.

New themes will usually be promoted on Hugo's official Twitter account. If you would like to be mentioned in the tweet please add your Twitter username to this submission.

Link to my Twitter account (optional): https://twitter.com/s4n7h0

Feel free to ask questions. We're glad to help.

digitalcraftsman commented 4 years ago

Hello Sanoop,

thank you for sharing this theme with the Hugo community 👍

While reviewing your theme I noted the absence of the images folder. Please add a thumbnail and screenshot in the images as described in the README.

Note for myself: whitelist theme to enable timeline

s4n7h0 commented 4 years ago

Hi @digitalcraftsman I have added the screenshot in the images folder now and also updated the readme file. Thanks for highlighting.

digitalcraftsman commented 4 years ago

Please add both screenshots in the requried dimensions and with the right filenames (casing matters). In Firefox you can create screenshots of a website with specific dimensions by pressing CTRL+SHIFT+m.

s4n7h0 commented 4 years ago

I have added both images in the required dimensions now. please check now.

digitalcraftsman commented 4 years ago

Thank you for adding the screenshots. Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

s4n7h0 commented 4 years ago

I just noticed the screenshot on the page (https://themes.gohugo.io/hugo-theme-timeline/) is not loading somehow. The path seems correct though. Can you please take a look, when time permits. Thanks

digitalcraftsman commented 4 years ago

The build script for www.themes.gohugo.io uses a regex to replace such urls because https://github.com/s4n7h0/hugo-theme-timeline/blob/main/images/screenshot.png points to an HTML page, not the actual image. The regex didn't match in your case because the to be replaced url to the image is expected to have the master branch as part of the url. You however are using main as source branch, hence a different url and no regex match.

tldr: use the link to the actual image instead: https://raw.githubusercontent.com/s4n7h0/hugo-theme-timeline/main/images/screenshot.png

Themes are updated every 3 days automatically.

s4n7h0 commented 4 years ago

You are right. I just updated the readme.