Closed RainerChiang closed 4 years ago
Hello @RainerChiang,
thank you for sharing this theme with the Hugo community. While reviewing your theme I noticed two minor issues:
To ease the maintenance of the demo content hosted at www.themes.gohugo.io most themes use the default content provided by the https://github.com/gohugoio/hugoBasicExample. Your theme's demo still works fine. Only the projects page wouldn't be generated, which doesn't use a custom layout or shows any new features.
By using the hugoBasicExample's content there would still remain the link that points to a (here) non-existing page. Would it be possible to remove the link from the config?
Alternatively, we can add your theme and showcase it at themes.gohugo.io you would refer to a self-hosted demo of your theme that isn't bound to such limitations (as you already do). It would look like this (note the missing demo button).
@digitalcraftsman
Thanks.
I've removed the link of project page in config.toml and fix some errors. I test my theme with the content of hugoBasicExample again, it works well.
Thanks for agreeing to this compromise. Your theme is already live on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.
A little feedback: I've checked the demo in browser with dark mode enabled. The contrast between the links to posts and the dark blue background is not very high (see screenshot).
@digitalcraftsman Thanks a lot. I haven't adapted my theme to the dark mode yet, I may enable it later.
Theme submission
Link to my theme repository: https://github.com/RainerChiang/simpleness
I made sure that...
README.md
describing my themeLICENSE.md
theme.toml
images/
folder with the required dimensionshttps://example.com
is set as base url inexampleSite/config.{toml, yaml, json}
to avoid the abuse of unused domainstoCSS
andPostCSS
that I have committed the/resources
directory with all generated assets, for my theme to work in the basic version of HugoN.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. If a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.
New themes will usually be promoted on Hugo's official Twitter account. If you would like to be mentioned in the tweet please add your Twitter username to this submission.
Link to my Twitter account (optional): https://twitter.com/ChiangRainer
Feel free to ask questions. We're glad to help.