search

gohugoio / hugoThemes

A curated directory of Hugo themes
https://themes.gohugo.io/
MIT License
1.77k stars 244 forks source link

Theme Submission: Simple Resume #931

Closed tylersayshi closed 4 years ago

tylersayshi commented 4 years ago

Theme submission

Link to my theme repository: https://github.com/tylerjlawson/simple-resume

I made sure that...

New themes will usually be promoted on Hugo's official Twitter account. If you would like to be mentioned in the tweet please add your Twitter username to this submission.

Link to my Twitter account (optional): I do not have Twitter, but would love a shout out by name

Feel free to ask questions. We're glad to help.

I noticed that the script to test the theme build has the first line as # /bin/bash. I believe this should instead be #!/bin/bash Is this something you'd be ok with receiving a PR for? I know you do not want PRs for themes, but I wasn't sure since this was different.

digitalcraftsman commented 4 years ago

Hello Tyler,

thank you for sharing this theme with the Hugo community 👍

While reviewing your theme I encountered an error regarding the stylesheets in the head partial. Please add a $ sign in front of style in line 6. Otherwise style is interpreted as a call of a function (that does not exist), not as a variable.

I noticed that the script to test the theme build has the first line as # /bin/bash. I believe this should instead be #!/bin/bash Is this something you'd be ok with receiving a PR for? I know you do not want PRs for themes, but I wasn't sure since this was different.

Thanks for pointing this out. It has already been fixed in https://github.com/gohugoio/hugoThemes/commit/d97c8f0e2b488a9c11d1cf5c6e8402f835adf7be. Theme submissions as PRs are best avoided because the proved to be inefficient during a review because it adds another layer between me and the source code. PRs for such things, typos etc. are always welcome.

digitalcraftsman commented 4 years ago

And please make sure that the thumbnail and screenshot in the images folder have the right dimensions. You can find them in the README.

tylersayshi commented 4 years ago

Hello @digitalcraftsman

Thanks for taking a look at that and answering my question. Thanks also for finding that bug I had, I am not sure why I didn't see the error during my local development, but I appreciate you catching that.

Here is the commit with the fix: https://github.com/tylerjlawson/simple-resume/commit/fb819a9b4835e464780c347bcbba9fc442633f4c

tylersayshi commented 4 years ago

My apologies about the thumbnail size, I have since fixed the dimensions to be 900x600 for the thumbnail. The screenshot should be the 1500x1000 per the READMEs request.

digitalcraftsman commented 4 years ago

Thanks for fixing the issues. Your theme is already live on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

tylersayshi commented 4 years ago

I noticed the image in my readme breaks when it is put onto the theme site so I updated my readme. Will the website automatically rebuild to reflect that change or is that process done manually?

digitalcraftsman commented 4 years ago

I noticed the image in my readme breaks when it is put onto the theme site so I updated my readme.

That's because the relative path you've used works on Github, but the directory structure of your repo isn't the same as on www.themes.gohugo.io. Instead of removing the screenshot you could use an absolute path: https://raw.githubusercontent.com/tylerjlawson/simple-resume/3495ff7d4351510595820d08a7f3b01733197e75/images/screenshot.png

Will the website automatically rebuild to reflect that change or is that process done manually?

Theme updates happen automatically every 3 days, the next update should be scheduled within the next 24 hours.

tylersayshi commented 4 years ago

Thank you @digitalcraftsman