How to handle missing Git refs

[bep]

I'm about to fix/get the build running, but thought I would open this issue to discuss how we handle this in the future.

In my head there are 2 common error situation.

1. invalid version: unknown revision
2. checksum mismatch for the go.sum file.

For the two variants above:

1. Is most likely unversioned theme (we use the last commit ref) where the theme owner have done a git push -f so the ref is gone. It could also be a versioned theme where the theme author has deleted the tag on GitHub.
2. This is most likely a versioned theme where a theme author has replaced the tag on GitHub.

Assuming this is most likely the theme authors' mistake, we could just remove the problematic themes, but the pragmatic approach is probably:

1. Remove the theme from build/go.mod and commit. It will be reconstructed from themes.txt.
2. Remove the build/go.sum and commit it.

/cc @hugo-sid

[hugo-sid]

Assuming this is most likely the theme authors' mistake, we could just remove the problematic themes, but the pragmatic approach is probably:

1. Remove the theme from build/go.mod and commit. It will be reconstructed from themes.txt.
2. Remove the build/go.sum and commit it.

I agree that this is a better way to handle things. Removing the theme from build/go.mod & build/go.sum is not sufficient. In the past, when dealing with CI problems, I had to remove the theme from these files as well:

• cmd/hugothemesitebuilder/build/cache/0000.githubrepos.json
• cmd/hugothemesitebuilder/build/config.json

References:

• https://github.com/gohugoio/hugoThemesSiteBuilder/pull/361
• https://github.com/gohugoio/hugoThemesSiteBuilder/pull/293, https://github.com/gohugoio/hugoThemesSiteBuilder/pull/294
• https://github.com/gohugoio/hugoThemesSiteBuilder/pull/338

[bep]

Removing the theme from build/go.mod & build/go.sum is not sufficient. In the past, when dealing with CI problems, I had to remove the theme from these files as well:

Note that I'm talking about the 2 specific error cases above, not "every CI problem".

[hugo-sid]

Note that I'm talking about the 2 specific error cases above, not "every CI problem".

I see.

One commendable action you've taken is removal of the cache step in the GitHub action workflow.

[bep]

I'm working on fixing the build / making it more robust now.

[bep]

I have adjusted the builds to improve this, esp. see my comment in f844650f2793dbdac9116286da7684a5a780b84d I'm closing this for now.