search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
214 stars 194 forks source link

Add theme simple-slideshow-hugo #366

Closed D00NIK closed 11 months ago

netlify[bot] commented 11 months ago

Deploy Preview for hugothemes ready!

Name Link
Latest commit ff645a8d78679f6e4e9ef84f3b948843ce6e2c94
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/651eec356df2f20008b3684c
Deploy Preview https://deploy-preview-366--hugothemes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hugo-sid commented 11 months ago

Hello @D00NIK,

We appreciate your submission, and thank you for taking the time to contribute.

Upon review, I noticed that your repository primarily contains a layout file at layouts/shortcodes/simple-slideshow.html. From a Hugo perspective, your repository appears to function more as a shortcode than a comprehensive theme.

We believe that 'themes' enable website creation. We need to evaluate whether your repository aligns with this criteria to be included in this list.

Your understanding and cooperation in this matter is greatly appreciated.

/cc: @bep Shall we consider creating an official list of Hugo shortcodes (just like themes)?

D00NIK commented 11 months ago

Of course I understand.

But I must point out that there is already Gallery Deluxe created by @bep which is already present on the list. It is pretty similar to mine but working as a partial (and using hugo modules) thought. It was even my inspiration to create my own version but using shortcode instead.

@hugo-sid

bep commented 11 months ago

@hugo-sid we have had similar discussions before, and we should find a way to present useful modules (e.g. shortcode collections etc.), but we're not there yet ... I think this needs to wait.

Re. Gallery Deluxe (which is my thing), to my defense, it does create a complete site.

But I had a look at your shortcode, and it looks very nice, but as I said, we need to find a better way of handling this (down the road).

D00NIK commented 11 months ago

Re. Gallery Deluxe (which is my thing), to my defense, it does create a complete site.

I guess I didn't look into it enough.

@hugo-sid we have had similar discussions before, and we should find a way to present useful modules (e.g. shortcode collections etc.), but we're not there yet ... I think this needs to wait.

That's okay, I'll close the pull request. I'll add it again when the time comes.