search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
214 stars 192 forks source link

add theme tldr.sh #415

Closed mansoorbarri closed 6 months ago

netlify[bot] commented 7 months ago

Deploy Preview for hugothemes ready!

Name Link
Latest commit 16a8340cb2569ccef8d6442421752f1ce9dafde7
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65bf18acf66cf000089b5480
Deploy Preview https://deploy-preview-415--hugothemes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hugo-sid commented 6 months ago

Hey there! Thanks for showing interest in contributing to Hugo themes.

After going through your readme:

A clone of tldr.sh for hugo site generator

I observed that your theme seems to be just a landing page of tldr.sh and not exactly a clone. Technically speaking, the Single page template (like layouts/_default/single.html) is missing, which makes it clear that your theme isn't a clone.

Could you please update the description of your theme to accurately reflect its features or implement features that match the description provided in the readme?

Please feel free to open another PR if you resolve any of the issues. Thanks!

mansoorbarri commented 6 months ago

@hugo-sid, Can I not mention that its a clone of a website even if the original website is not on Hugo? && it doesn't have any single.html file because the theme is controlled entirely by config.toml file.